[tor-bugs] #20559 [Core Tor/Tor]: rend_config_services ignores failures in rend_add_service

[Tor Bug Tracker & Wiki]

#20559: rend_config_services ignores failures in rend_add_service
-------------------------------------+------------------------------------
 Reporter:  teor                     |          Owner:
     Type:  defect                   |         Status:  needs_review
 Priority:  Medium                   |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor             |        Version:  Tor: 0.2.7.1-alpha
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-hs, review-group-12  |  Actual Points:  0.3
Parent ID:                           |         Points:  0.1
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------------
Changes (by teor):

 * parent:  #20484 =>
 * actualpoints:  0.1 => 0.3


Comment:

 My branch bug20599_030_v2 on github fixes this issue.

 It passes all the standard checks, plus those in:
 https://trac.torproject.org/projects/tor/ticket/20638#comment:8

 It fails as expected on the following config, which would previously have
 been ignored:
 {{{
 src/or/tor HiddenServiceDir /tmp/tor.$$.anon HiddenServicePort 80
 DataDirectory /tmp/tor.$$ SocksPort 0 PidFile /tmp/tor.pid ControlPort
 12345 HiddenServiceDir /tmp/tor.$$.anon HiddenServicePort 80
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20559#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online