[tor-bugs] #20638 [Core Tor/Tor]: Non-anonymous single-hop HS enabled tor doesn't detect already existing anonymous, HS at start-up

[Tor Bug Tracker & Wiki]

#20638: Non-anonymous single-hop HS enabled tor doesn't detect already existing
anonymous, HS at start-up
--------------------------+------------------------------------
 Reporter:  ahf           |          Owner:  teor
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.9.3-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs, sos   |  Actual Points:  1.0
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * points:   => 0.5
 * actualpoints:   => 1.0


Comment:

 My branch bug20638_029 on github fixes this issue.

 Passes:
 * make check
 * make check-spaces
 * make test-network-all
 * The 4 directory tests in
 https://trac.torproject.org/projects/tor/ticket/20484#comment:3
 * The following two tests work, even when repeated, but fail as expected
 when used with the HiddenServiceDir with non-matching anonymity:
 Non-Anonymous:
 {{{
 src/or/tor HiddenServiceDir /tmp/tor.$$.nonanon HiddenServicePort 80
 DataDirectory /tmp/tor.$$ HiddenServiceNonAnonymousMode 1
 HiddenServiceSingleHopMode 1 SocksPort 0 PidFile /tmp/tor.pid ControlPort
 12345
 }}}
 Anonymous:
 {{{
 src/or/tor HiddenServiceDir /tmp/tor.$$.anon HiddenServicePort 80
 DataDirectory /tmp/tor.$$ SocksPort 0 PidFile /tmp/tor.pid ControlPort
 12345
 }}}
 * They also re-read their existing config ok when HUP'd.

 Using stem's tor-prompt works fine, with the expected failure when
 Flags=NonAnonymous does not match the anonymity setting:
 {{{
 ./tor-prompt -i 12345
 ADD_ONION NEW:BEST Port=1234 [Flags=NonAnonymous]
 DEL_ONION <service-id>
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20638#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online