[tor-bugs] #20610 [Core Tor/Tor]: Rate limit router_pick_published_address log message

[Tor Bug Tracker & Wiki]

#20610: Rate limit router_pick_published_address log message
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.8.9
 Severity:  Normal        |     Resolution:
 Keywords:  regression    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 directory_fetches_from_authorities() is called in maint-0.2.9 from six
 places:

 * directory.c's directory_get_from_dirserver(), when we launch a new
 directory fetch/post of any kind.

 * directory.c's dir_routerdesc_download_failed() and
 dir_microdesc_download_failed(), which are called when we didn't get a
 descriptor we wanted, to decide how to proceed.

 * dirserv.c's directory_fetches_dir_info_early(), which is used to decide
 schedules for fetching the new consensus and for fetching new descriptors
 we just learned about.

 * main.c's directory_info_has_arrived() which we call whenever we finish
 receiving any directory object.

 * main.c's fetch_networkstatus_callback(), which is called once a second
 during bootstrap and once a minute otherwise.

 * networkstatus.c's networkstatus_consensus_can_use_extra_fallbacks(),
 which is new and called from a variety of places so I'm suspicious of it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20610#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online