[tor-bugs] #20610 [Core Tor/Tor]: Rate limit router_pick_published_address log message

[Tor Bug Tracker & Wiki]

#20610: Rate limit router_pick_published_address log message
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.8.9
 Severity:  Normal        |     Resolution:
 Keywords:  regression    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 router_pick_published_address() is called in maint-0.2.9 from five places:

 * In control.c's getinfo_helper_misc(), in response to a 'getinfo address'
 request. I think it's fair to say that's not our culprit.

 * In dirserv.c's directory_fetches_from_authorities(). This is very likely
 the problem.

 * In router.c's router_rebuild_descriptor() when the current descriptor is
 dirty, to see if we don't know our address so we should short-circuit the
 rest of this function until we do.

 * In router.c's router_build_fresh_descriptor() to make sure we didn't try
 to build a descriptor mistakenly. I don't think rebuilding the descriptor
 happens too often, but hey I could be wrong.

 * In transports.c's pt_get_extra_info_descriptor_string(), to figure out
 what address to write in our extrainfo descriptor when we're offering a
 pluggable transport. I'm also not worried about this one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20610#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online