[tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE and other bugs in weight status document processing

[Tor Bug Tracker & Wiki]

#19259: uncaught NFE and other bugs in weight status document processing
-----------------------------+-----------------------------------
 Reporter:  iwakeh           |          Owner:  iwakeh
     Type:  defect           |         Status:  needs_review
 Priority:  High             |      Milestone:  Onionoo 3.1-1.0.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Major            |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------------

Comment (by iwakeh):

 Replying to [comment:20 karsten]:
 > Replying to [comment:19 iwakeh]:
 > > Please find
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git?h=task-19259 my
 branch] for review.
 > >
 > > It has four commits on top of the current master.  Two tweaking the
 build environment, one for the tests and another for making the new tests
 pass.
 >
 > Looks good.  I made a few tweaks in fixup commits in
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-19259
 my task-19259 branch].  Please take a look, and if you like them, I'll
 squash them into yours.

 All fine.  Thanks for checking.

 >
 > > One question:  Should negative values still be recognized as missing
 values (cf. comment:15)?
 >
 > Uhhhhhm, do you mind rephrasing that question and giving a bit more
 context?  I could re-read the comments above, but maybe you can explain
 this in 2 or 3 sentences?  Thanks!

 I'm concerned about deployment:  When making this code run on an existing
 Onionoo server, will it encounter old weight status docs (i.e. with
 negative values for missing entries) that need to be processed?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19259#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online