[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes

[Tor Bug Tracker & Wiki]

#20458: Integration tests should be run locally before committing code changes
--------------------------+------------------------------------
 Reporter:  chelseakomlo  |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  test, doc     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------

Comment (by chelseakomlo):

 Replying to [comment:3 cypherpunks]:
 > Replying to [ticket:20458 chelseakomlo]:
 > > 2. Adding a make task that runs all necessary tasks before
 contributing new code
 > `make check` is the default target for running tests so I'd move every
 test under this target. This will also make the jenkins builds run these
 tests automatically, making catching issues easier.

 I think the issue with Jenkins running `make check` for the entire test
 suite is that chutney tests are currently non-deterministic. Until we feel
 confident in the output from chutney tests, we should keep running these
 as a seperate task so that we have confidence when the build passes or
 fails.

 Agreed that this should be the ultimate goal, but eliminating flakiness in
 chutney tests is currently a blocker.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online