[tor-bugs] #20646 [Core Tor/Tor]: finish_writing_to_file_impl() should remove temporary file if replacing an existing one failed

[Tor Bug Tracker & Wiki]

#20646: finish_writing_to_file_impl() should remove temporary file if replacing an
existing one failed
------------------------------+--------------------------------
     Reporter:  fk            |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:  Tor: 0.2.9.5-alpha
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Functions like start_writing_to_file() rely on
 finish_writing_to_file_impl() to remove the temporary
 file if replacing an already existing one failed.

 Currently this doesn't happen. The attached patch fixes this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20646>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online