[tor-bugs] #20630 [Core Tor/Tor]: tor_fragile_assert hit in connection_ap_handshake_rewrite_and_attach

[Tor Bug Tracker & Wiki]

#20630: tor_fragile_assert hit in connection_ap_handshake_rewrite_and_attach
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * milestone:   => Tor: 0.3.0.x-final


Comment:

 Oh wow, that commit was suppose to be only documentation... we should
 investigate what else that commit did changed in the code.

 I see this:

 {{{
 +    /* Now see if this is a connect request that we can reject
 immediately */
 +    if (socks->command == SOCKS_COMMAND_CONNECT) {
 }}}

 {{{
 +    } else {
 +      tor_assert_nonfatal_unreached_once();
 }}}

 {{{
 +    if (retval < 1) {
 +      /* We were either told "-1" (complete failure) or 0 (circuit in
 +       * progress); we can't attach this stream yet. */
        return retval;
 +    }
 }}}

 {{{
 -    uint8_t new_circ_purpose;
 ...
 +    /* What purpose do we need to launch this circuit with? */
 +    uint8_t new_circ_purpose;
 }}}

 TBH, safe bet here would be to revert, clean that patch again for ONLY
 comments and extra commit(s) for any code change. That commit hasn't been
 released so not that problematic.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20630#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online