[tor-bugs] #20568 [Core Tor/Tor]: Move encode_cert() from hs_descriptor.c into torcert.c
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Nov 10 16:07:48 UTC 2016
#20568: Move encode_cert() from hs_descriptor.c into torcert.c
---------------------------------------+-----------------------------------
Reporter: dgoulet | Owner:
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor:
| 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, easy, refactoring | Actual Points:
Parent ID: | Points: 0.1
Reviewer: | Sponsor: SponsorR-can
---------------------------------------+-----------------------------------
Changes (by dgoulet):
* status: needs_revision => needs_review
Comment:
Thanks neel! lgtm! I only fixed one thing which is that I put back this
comment in the code ;).
{{{
-/* === ENCODING === */
}}}
I've put the patch in a branch and added an extra fixup commit for the
above: `ticket20568_030_01`
NOTE: this patch doesn't make `router.c` use this function, it's only use
by the HS subsystem so far. So maybe a second ticket once this merged on
actually using this interface in the code.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20568#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list