[tor-bugs] #20509 [Core Tor/Tor]: Directory authorities should take away Guard flag from relays with #20499 bug

[Tor Bug Tracker & Wiki]

#20509: Directory authorities should take away Guard flag from relays with #20499
bug
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.9
 Severity:  Normal                               |     Resolution:
 Keywords:  028-backport, easy,                  |  Actual Points:
  TorCoreTeam201611                              |
Parent ID:                                       |         Points:
 Reviewer:  teor, arma                           |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => merge_ready
 * reviewer:   => teor, arma
 * version:  Tor: 0.2.9.1-alpha => Tor: 0.2.8.9


Comment:

 Replying to [comment:19 teor]:
 > Ok, next steps are:
 > * run the unit tests in a few different environments,

 The code works on macOS 10.12.1 x86_64 and i386, and Ubuntu 16.0.4 x86_64.

 > * run this code in a local test network using chutney,

 Chutney runs the code successfully, but ignores the actual Guard
 assignments because of TestingDirAuthVoteGuard.

 > * run this code on a test directory authority and make sure it takes
 away the guard flag.

 Turns out there need to be two separate patches for this:
 * rubiate's `ticket20509` works for master and 0.2.9
 * my `ticket20509_028` works for 0.2.8
   * authorities require the stable flag for the guard flag in 0.2.9 (merge
 issue)
   * we added BUG in 0.2.9 (replaced with log_warn(LD_BUG, ...))

 I can test the voting for the 0.2.8 patch on the test network, but not the
 consensus, because the test network uses consensus method 26, and 0.2.8
 only has 22. But I looked at the vote, and the only versions getting Guard
 are 0.2.8.9 and 0.2.9.5-alpha.

 This is the same for the patch to master (I only have 2 test authorities,
 so no 0.2.9 test yet), it is only voting Guard for 0.2.8.9 and
 0.2.9.5-alpha.

 (In fact, my two authorities disagree on whether a third 0.2.9.5-alpha
 relay should get Guard, which demonstrates that the existing requirements
 are still being imposed.)

 I also checked the authority logs and they're fine.

 > Around about the last step, we can consider merging it to 0.2.9 and
 master.
 > ...

 I would be happy to see this merged, at least to 0.2.9 and master, with a
 backport to 0.2.8 after it has received a bit more testing (for example,
 arma testing it on moria1 on 0.2.8.9?).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20509#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online