[tor-bugs] #19875 [Core Tor/Tor]: shuffle our bridges when we load them from config

[Tor Bug Tracker & Wiki]

#19875: shuffle our bridges when we load them from config
--------------------------+------------------------------
 Reporter:  arma          |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------

Comment (by arma):

 If I were wanting to test this, I would want to verify my expectations
 that whatever order it chose on the first run, on the *second* run, i.e.
 after it's committed to an ordering in the state file, it sticks with that
 ordering.

 Also I might want to verify my expectations that when I have a pile of
 bridge addresses, and then I try to use a bridge, Tor will hand me the
 first 'up' one in the state file.

 Verifying that the shuffle actually shuffles the list is pretty far down
 on my list of things I'd expect a unit test to test here.

 But take all of this with a grain of salt since I am not skilled at unit
 tests. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19875#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online