[tor-bugs] #20596 [Metrics]: add jdk version to manifest files

[Tor Bug Tracker & Wiki]

#20596: add jdk version to manifest files
-------------------------+------------------------------
 Reporter:  iwakeh       |          Owner:  metrics-team
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Like this?

 {{{
 diff --git a/build.xml b/build.xml
 index 794188f..e36b780 100644
 --- a/build.xml
 +++ b/build.xml
 @@ -199,6 +199,7 @@
          <attribute name="Implementation-Title" value="DescripTor"/>
          <attribute name="Implementation-Version"
                     value="${release.version}-${git.revision}"/>
 +        <attribute name="JDK-Version" value="${java.runtime.version}"/>
        </manifest>
      </jar>
      <jar destfile="${jarsourcesfile}">
 @@ -209,6 +210,7 @@
          <attribute name="Implementation-Title" value="DescripTor"/>
          <attribute name="Implementation-Version"
                     value="${release.version}-${git.revision}"/>
 +        <attribute name="JDK-Version" value="${java.runtime.version}"/>
        </manifest>
      </jar>
      <jar destfile="${jardocsfile}">
 @@ -218,6 +220,7 @@
          <attribute name="Implementation-Title" value="DescripTor"/>
          <attribute name="Implementation-Version"
                     value="${release.version}-${git.revision}"/>
 +        <attribute name="JDK-Version" value="${java.runtime.version}"/>
        </manifest>
      </jar>
    </target>
 }}}

 Result is as follows:

 {{{
 diff -Nur x/META-INF/MANIFEST.MF y/META-INF/MANIFEST.MF
 --- x/META-INF/MANIFEST.MF      2016-11-08 14:12:16.000000000 +0100
 +++ y/META-INF/MANIFEST.MF      2016-11-08 14:13:30.000000000 +0100
 @@ -3,4 +3,5 @@
  Created-By: The Tor Project
  Implementation-Title: DescripTor
  Implementation-Version: 1.5.0-dev-dd4b395
 +JDK-Version: 1.8.0_102-b14
 }}}

 If this looks good, I'll make this change in metrics-lib, CollecTor, and
 Onionoo.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online