[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

[Tor Bug Tracker & Wiki]

#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201611R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * keywords:  tbb-torbutton-conversion, TorBrowserTeam201611 => tbb-
     torbutton-conversion, TorBrowserTeam201611R


Comment:

 Replying to [comment:43 mcs]:

 Thanks for your help working out these issues!

 > Unfortunately, Kathy and I still see this problem. We also tested on an
 older OSX 10.11.6 system to remove Sierra and the Retina display from the
 equation, but the problem still occurred. It definitely looks like
 quantizeBrowserSize() running too early is causing the problem, because if
 I change the setTimeout() delay to 5000ms the window is sized correctly.

 Strange -- I can't seem to reproduce this on my Mac. I don't have Sierra,
 but as you say, you also saw the problem on an old system. Here's another
 version of the torbutton patch (rebased onto master) where I use a "xul-
 window-visible" observer instead of setTimeout(...,0). Maybe this will
 work on your system? Hopefully it's easy to test because you can keep the
 C++ build and just install the new xpi.

 https://github.com/arthuredelstein/torbutton/commit/19459+3

 If this doesn't work, I can also post a patch that retains a
 MutationObserver from the old torbutton code. It's an awkward hack so I'd
 rather figure out how to do this correctly without it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online