[tor-bugs] #20573 [Core Tor/Tor]: The build_mac() function in hs_descriptor.c should be made generic for the entire code base

[Tor Bug Tracker & Wiki]

#20573: The build_mac() function in hs_descriptor.c should be made generic for the
entire code base
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, crypto,             |  Actual Points:
  TorCoreTeam201611                              |
Parent ID:                                       |         Points:  0.2
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  new => needs_review


Comment:

 Ok took a stab at it. See branch: `ticket20573_030_01`.

 One thing that could be an improvement is maybe renaming the function to
 contain "256" or else offer a "bits" variable for the size of the SHA3 or
 we think SHA3-256 is what should be used all the time :).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20573#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online