[tor-bugs] #20533 [Core Tor/Tor]: Each download request should only increment the failure count once

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 7 14:22:41 UTC 2016


#20533: Each download request should only increment the failure count once
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
                                                 |  reopened
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, CoreTorTeam201611,       |  Actual Points:  0.2
  029-proposed                                   |
Parent ID:  #20499                               |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Hmm, actually, for consistency with update_networkstatus_downloads, we
 can't wait any longer than valid_until. Otherwise we would start
 downloading a new consensus while waiting for certificates on the old one.

 {{{
     if (! (c && c->valid_after <= now && now <= c->valid_until)) {
       /* No live consensus? Get one now!*/
       time_to_download_next_consensus[i] = now;
     }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20533#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list