[tor-bugs] #19646 [Obfuscation/meek]: Mac OS: wrong location for meek browser profile

[Tor Bug Tracker & Wiki]

#19646: Mac OS: wrong location for meek browser profile
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  dcf
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Obfuscation/meek                     |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-regression, tbb-6.0-issues,      |  Actual Points:
  meek, TorBrowserTeam201611R                    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dcf):

 Replying to [comment:8 brade]:
 > Two patches are needed, one for meek (which I just attached to this
 ticket) and one for Tor Launcher, which is here:
 > https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug19646-01&id=5ac452d86f93ee15ba3722afc606be862e8f3686
 >
 > Please review both patches.

 As a potential improvement, let me know what you think about this.
 `torDataDirFirefoxProfilePath` is an empty string on linux and windows.
 It's only non-empty on mac. Therefore, the first branch of the `if` will
 only ever be taken on mac:
 {{{
         var profilePath string
         var torDataDir = os.Getenv("TOR_BROWSER_TOR_DATA_DIR")
         if torDataDir != "" && torDataDirFirefoxProfilePath != "" {
                 profilePath = filepath.Join(torDataDir,
 torDataDirFirefoxProfilePath)
         } else {
                 profilePath, err = filepath.Abs(firefoxProfilePath)
                 if err != nil {
                         return
                 }
         }
 }}}
 Does it make sense to remove the check for `torDataDirFirefoxProfilePath
 != ""`, and just make `TOR_BROWSER_TOR_DATA_DIR` and
 `torDataDirFirefoxProfilePath` the primary way of choosing the path on all
 platforms? `firefoxProfilePath` can remain as a fallback, only used if
 `TOR_BROWSER_TOR_DATA_DIR` is not set. I say this because the
 [https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug19646-01&id=5ac452d86f93ee15ba3722afc606be862e8f3686
 tor-launcher patch] unconditionally sets `TOR_BROWSER_TOR_DATA_DIR`, and
 it's surprising that the environment variable will be ignored on platforms
 other than mac.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19646#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online