[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

[Tor Bug Tracker & Wiki]

#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:40 mcs]:

 Thanks again for the review.

 > Kathy and I were actually more concerned about removal of
 `extensions.torbutton.window.innerWidth` / `innerHeight`. Without those
 prefs, there should be no way to get a window that is wider than 1000
 pixels at startup, for example. I guess someone needs to make the call on
 whether it is okay to remove this functionality.

 I have altered privacy.window.maxInnerWidth and
 privacy.window.maxInnerHeight so that they now replace the default
 1000x1000. So the user can specify that the window be smaller or larger
 than the default, but it will also stay within the availScreen and always
 be rounded.

 > The changes looked okay to Kathy and me, but when we tested on a Retina
 Mac with Sierra (OSX 10.12.1), we saw incorrect results (content window
 size was 1300 x 700 at startup).

 I can't exactly reproduce this result (maybe because I don't have Sierra),
 but I also saw an incorrect result on another version of OS X. It turns
 out that the code inside quantizeBrowserSize() was running too early and
 interfering with the startup resizing. So I added a setTimeout(..., 0) and
 the problem went away for me.

 This revision:
 https://github.com/arthuredelstein/tor-browser/commit/19459+15
 https://github.com/arthuredelstein/torbutton/commit/19459+2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online