[tor-bugs] #20560 [Core Tor/Tor]: Some unit tests fail when logging messages on Windows / MinGW64

[Tor Bug Tracker & Wiki]

#20560: Some unit tests fail when logging messages on Windows / MinGW64
------------------------------------+------------------------------------
 Reporter:  teor                    |          Owner:
     Type:  defect                  |         Status:  new
 Priority:  Medium                  |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor            |        Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal                  |     Resolution:
 Keywords:  windows, mingw64, test  |  Actual Points:
Parent ID:                          |         Points:  1
 Reviewer:                          |        Sponsor:
------------------------------------+------------------------------------

Comment (by nickm):

 Ah, the configure output is in #20530:
 {{{
 checking for vasprintf... no
 checking for _vscprintf... yes
 }}}
 That's clear enough.

 So either the first _vcsprintf call is returning a negative value, or the
 second _vcsprintf call is returning a mismatched length.

 Hm. I wonder, are we missing an intervening call to va_copy here?

 I'm attaching a patch that should fix the problem, if that is the problem.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20560#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online