[tor-bugs] #20484 [Core Tor/Tor]: HiddenServiceDir must already exist when making a Single Onion Service

[Tor Bug Tracker & Wiki]

#20484: HiddenServiceDir must already exist when making a Single Onion Service
----------------------------------+------------------------------------
 Reporter:  pastly                |          Owner:
     Type:  defect                |         Status:  needs_revision
 Priority:  Medium                |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.2.9.3-alpha
 Severity:  Normal                |     Resolution:
 Keywords:  tor-hs, single-onion  |  Actual Points:  0.5
Parent ID:                        |         Points:  0.2
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Question: Why don't we try to create the directory in
 `rend_config_services()` (for each service that your patch does) instead
 of in `rend_service_load_all_keys()` which is called much later in
 config.c. Basically, I think if we do ask for creation when configuring
 the services, we then have no need for it in the load keys function. I did
 the test and works well.

 The rest lgtm so whatever you decide, feel free to `merge_ready` this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20484#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online