[tor-bugs] #20551 [Core Tor/Tor]: Implicit conversion warnings with openssl 1.1 on 32-bit platforms (was: Implicit conversion warnings with openssl 1.1)

[Tor Bug Tracker & Wiki]

#20551: Implicit conversion warnings with openssl 1.1 on 32-bit platforms
---------------------------------------+-----------------------------------
 Reporter:  nickm                      |          Owner:
     Type:  defect                     |         Status:  new
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.2.9.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  029-backport 028-backport  |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------
Changes (by nickm):

 * keywords:   => 029-backport 028-backport
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.9.x-final


Old description:



New description:

 {{{
 13:25:05 src/common/tortls.c:1650:30: error: implicit conversion loses
 integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned
 long' [-Werror,-Wshorten-64-to-32]
 13:25:05   result->last_write_count = BIO_number_written(bio);
 13:25:05                            ~ ^~~~~~~~~~~~~~~~~~~~~~~
 13:25:05 src/common/tortls.c:1651:29: error: implicit conversion loses
 integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned
 long' [-Werror,-Wshorten-64-to-32]
 13:25:05   result->last_read_count = BIO_number_read(bio);
 13:25:05                           ~ ^~~~~~~~~~~~~~~~~~~~
 13:25:05 src/common/tortls.c:2266:7: error: implicit conversion loses
 integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned
 long' [-Werror,-Wshorten-64-to-32]
 13:25:05   r = BIO_number_read(SSL_get_rbio(tls->ssl));
 13:25:05     ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 13:25:05 src/common/tortls.c:2287:7: error: implicit conversion loses
 integer precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned
 long' [-Werror,-Wshorten-64-to-32]
 13:25:05   w = BIO_number_written(wbio);
 13:25:05     ~ ^~~~~~~~~~~~~~~~~~~~~~~~
 13:25:05 4 errors generated.
 }}}

--

Comment:

 Branch `bug20551_028` has the fix here.  I'm applying it to master.  How
 far back to backport?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20551#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online