[tor-bugs] #18873 [Core Tor/Tor]: Refactor circuit_predict_and_launch_new()

[Tor Bug Tracker & Wiki]

#18873: Refactor circuit_predict_and_launch_new()
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:
     Type:  defect        |         Status:  needs_revision
 Priority:  Low           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  refactoring   |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Oh I see right... only general purpose so it's safe. Ok I think it's fine
 indeed and yes adding a comment saying "Well GENERAL purpose has to be an
 origin circuit" would be good idea so we are clear that after those
 conditions downcasting to an origin circuit is safe :).

 The rest lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18873#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online