[tor-bugs] #19180 [Core Tor/Tor]: Add new compiler warnings

[Tor Bug Tracker & Wiki]

#19180: Add new compiler warnings
--------------------------+------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  029-proposed  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------

Comment (by cypherpunks):

 The following change in 54610f721d66c41280e64674c27869eca381f059 got
 caught in the float suffix removal. The tests are not affected by it, but
 IMO it's still an erroneous change.

 {{{
 diff --git a/src/test/test_channeltls.c b/src/test/test_channeltls.c
 index f5fa50c..3a73c77 100644
 --- a/src/test/test_channeltls.c
 +++ b/src/test/test_channeltls.c
 @@ -51,7 +51,7 @@ test_channeltls_create(void *arg)
    channel_t *ch = NULL;
    const char test_digest[DIGEST_LEN] = {
      0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a,
 -    0x0b, 0x0c, 0x0d, 0x0e, 0x0f, 0x10, 0x11, 0x12, 0x13, 0x14 };
 +    0x0b, 0x0c, 0x0d, 0x0e, 0x0, 0x10, 0x11, 0x12, 0x13, 0x14 };

    (void)arg;

 @@ -97,7 +97,7 @@ test_channeltls_num_bytes_queued(void *arg)
    channel_t *ch = NULL;
    const char test_digest[DIGEST_LEN] = {
      0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a,
 -    0x0b, 0x0c, 0x0d, 0x0e, 0x0f, 0x10, 0x11, 0x12, 0x13, 0x14 };
 +    0x0b, 0x0c, 0x0d, 0x0e, 0x0, 0x10, 0x11, 0x12, 0x13, 0x14 };
    channel_tls_t *tlschan = NULL;
    size_t len;
    int fake_outbuf = 0, n;
 @@ -184,7 +184,7 @@ test_channeltls_overhead_estimate(void *arg)
    channel_t *ch = NULL;
    const char test_digest[DIGEST_LEN] = {
      0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0a,
 -    0x0b, 0x0c, 0x0d, 0x0e, 0x0f, 0x10, 0x11, 0x12, 0x13, 0x14 };
 +    0x0b, 0x0c, 0x0d, 0x0e, 0x0, 0x10, 0x11, 0x12, 0x13, 0x14 };
    double r;
    channel_tls_t *tlschan = NULL;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19180#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online