[tor-bugs] #19203 [Core Tor/Tor]: node_get_by_nickname() fails to give warning on unique-but-unnamed node.

[Tor Bug Tracker & Wiki]

#19203: node_get_by_nickname() fails to give warning on unique-but-unnamed node.
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  028-backport
Actual Points:                |  Parent ID:  #19180
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 There are two checks in node_get_by_nickname for listing an unnamed router
 by name.  One checks for `(smartlist_len(matches)>1 && warn_if_unnamed)`,
 whereas the other one also checks for `(smartlist_len(matches)>1 &&
 warn_if_unnamed)`.  Whoops.

 The impact is that if there is one match, no warning will be produced,
 even though it arguably should (now that Naming is no longer a thing).

 Found by GCC6 with -Wduplicated-cond as part of #19180.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19203>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online