[tor-bugs] #19021 [Metrics/CollecTor]: improve configuration process

[Tor Bug Tracker & Wiki]

#19021: improve configuration process
-------------------------------+------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip operation     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------
Changes (by iwakeh):

 * status:  new => needs_review


Comment:

 Configuration process is changed:

 * running the jar without any args will write the default properties files
 with the old defaults
 * all properties are set, i.e. no 'hidden' defaults
 * a properties file can be specified as second command line argument, if
 not, `collector.properties` in the current folder is used.
 * `Configuration` reads the properties and verifies there syntax, e.g.
 bool needs to be 'true' or 'false'.
 * A `Key` enum contains all the property keys.

 In addition:
 * Tests added for all new classes; and an overall smoke-test added to also
 verify the new configuration. (The tests are not allowed to contact the
 network, so they won't bother any production servers.)
 * Coverage for new classes up to 100%.
 * Removed `System.exit`s to make CollecTor more testable and in
 preparation for scheduler task.
 * ...

 Please review and test thoroughly.
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19021
 -improve-configuration-process my branch]
 In addition, I'll also test this version on the mirror.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19021#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online