[tor-bugs] #18982 [Core Tor/Tor]: Tor should log 1-based hop numbers

[Tor Bug Tracker & Wiki]

#18982: Tor should log 1-based hop numbers
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
 Priority:  Low                                  |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Minor                                |  0.2.9.x-final
 Keywords:  easy, logging, 029-nickm-says-yes,   |        Version:  Tor:
  review-group-2, CoreTorTeam201606              |  0.2.4.5-alpha
Parent ID:                                       |     Resolution:
 Reviewer:  arma                                 |  Actual Points:  1 hour
                                                 |         Points:  small
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Ok, I found a moment to look at the patch. It has the problem that I
 expected it to have: there's no way to tell now whether somebody giving us
 one of these lines is using the old code or the new code -- so now seeing
 a log line talking about "hop 1" is ambiguous about whether it's the first
 relay or the second relay.

 In the distant future, this issue won't matter anymore, because nobody
 will be using the old code. But the distant future is years away.

 I think an easy fix might be to change something else in each of these log
 lines too, so it's possible, given just the log line, to disambiguate?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18982#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online