[tor-bugs] #19179 [Core Tor/Tor]: Refactor functions that handle 'packages' in consensus/votes

[Tor Bug Tracker & Wiki]

#19179: Refactor functions that handle 'packages' in consensus/votes
------------------------------+--------------------------
     Reporter:  asn           |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Minor         |   Keywords:  tor-dirauth
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 This is a side issue of #18840.

 The code managing packages for consensuses and votes seems to be of
 particularly low quality.

 See compute_consensus_package_lines() doing ad-hoc parsing. And see
 validate_recommended_package_line() doing more ad-hoc parsing and having
 wrong return value patterns. Fortunately, both of them are weakly tested
 in the unittests.

 Maybe we should refactor and add more testing for these funcs?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19179>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online