[tor-bugs] #18840 [Core Tor/Tor]: dir auths vote "package" lines out of order
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu May 26 13:04:23 UTC 2016
#18840: dir auths vote "package" lines out of order
-------------------------------------------------+-------------------------
Reporter: arma | Owner: arma
Type: defect | Status:
Priority: Medium | merge_ready
Component: Core Tor/Tor | Milestone: Tor:
Severity: Minor | 0.2.9.x-final
Keywords: 029-nickm-says-yes, review-group-2, | Version:
TorCoreTeam201605 | Resolution:
Parent ID: | Actual Points:
Reviewer: nickm | Points: small
| Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* status: needs_review => merge_ready
Comment:
Patch works for me. Packages in votes seem ordered correctly.
---
As an almost off-topic matter, the code managing packages for consensuses
and votes seems to be of particularly low quality. See
`compute_consensus_package_lines()` doing ad-hoc parsing. And see
`validate_recommended_package_line()` doing more ad-hoc parsing and having
wrong return value patterns. Fortunately, both of them are weakly tested
in the unittests. Maybe we should do something about these functions....
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18840#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list