[tor-bugs] #7144 [Core Tor/Tor]: Implement Bridge Guards and other anti-enumeration defenses

[Tor Bug Tracker & Wiki]

#7144: Implement Bridge Guards and other anti-enumeration defenses
-------------------------------------------------+-------------------------
 Reporter:  karsten                              |          Owner:  isis
     Type:  project                              |         Status:
 Priority:  High                                 |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  SponsorZ, tor-bridge,                |        Version:
  027-triaged-1-out, 028-triage, 028-triaged,    |     Resolution:
  isis201604, isis201605, TorCoreTeam201605,     |  Actual Points:
  TorCoreTeam-postponed-201604                   |         Points:  3
Parent ID:                                       |        Sponsor:
 Reviewer:                                       |  SponsorS-can
-------------------------------------------------+-------------------------

Comment (by teor):

 Code review:

 `make` gives these warnings:
 {{{
 src/or/circuitbuild.c:304:65: warning: unused parameter 'verbose_names'
       [-Wunused-parameter]
 circuit_list_path_impl(origin_circuit_t *circ, int verbose, int
 verbose_names)
 ...
 src/or/loose.c:1077:49: warning: unused parameter 'layer_hint'
       [-Wunused-parameter]
                                   crypt_path_t *layer_hint, cell_t *cell)
                                                 ^
 src/or/loose.c:79:1: warning: unused function
       'loose_note_that_we_maybe_cant_complete_circuits' [-Wunused-
 function]
 loose_note_that_we_maybe_cant_complete_circuits(void)
 ...
 src/test/test_loose.c:404:12: warning: incompatible pointer to integer
       conversion initializing 'circid_t' (aka 'unsigned int') with an
 expression
       of type 'void *' [-Wint-conversion]
   circid_t circ_id = NULL;
 }}}
 The last one is repeated a few times.


 `make test` asserts and fails on:
 {{{
 scheduler/channel_states: [forking] May 23 15:18:46.937 [err]
 tor_assertion_fail
 ed_: Bug: src/or/circuitlist.c:420: circuit_get_all_pending_on_channel:
 Assertio
 n circ->state == CIRCUIT_STATE_CHAN_WAIT failed; aborting. (on Tor
 0.2.8.2-alpha
 -dev )
 ...
 2   libsystem_c.dylib                   0x00007fff8bf376e7 abort + 129
 3   test                                0x00000001084dbecb
 circuit_get_all_pending_on_channel + 299 (circuitlist.c:409)
 4   test                                0x00000001084d85ca
 circuit_n_chan_done + 90 (circuitbuild.c:630)
 5   test                                0x00000001084c903b channel_closed
 + 91 (channel.c:1338)
 6   test                                0x000000010846025c
 test_scheduler_channel_states + 2876 (test_scheduler.c:417)
 7   test                                0x00000001084bf4bf
 testcase_run_one + 863 (tinytest.c:106)
 8   test                                0x00000001084bf9d3 tinytest_main +
 531 (tinytest.c:432)
 9   test                                0x00000001084bee0f main + 639
 (testing_common.c:300)
 10  libdyld.dylib                       0x00007fff93e5f5ad start + 1
 }}}

 `make test-network-all` fails everything:
 {{{
 FAIL: basic-min
 FAIL: bridges-min
 FAIL: hs-min
 FAIL: bridges+hs
 FAIL: bridges+ipv6-min
 FAIL: ipv6-exit-min
 FAIL: mixed
 }}}

 I'll try to work out why.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7144#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online