[tor-bugs] #19013 [Core Tor/Tor]: Authorities shouldn't warn about reachability

[Tor Bug Tracker & Wiki]

#19013: Authorities shouldn't warn about reachability
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  new
 Priority:  Low           |      Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.8.2-alpha
 Severity:  Trivial       |     Resolution:
 Keywords:  logging easy  |  Actual Points:
Parent ID:                |         Points:  0.2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * keywords:  must-fix-before-028-rc, TorCoreTeam201605, logging => logging
     easy
 * priority:  Medium => Low
 * points:  1 => 0.2
 * severity:  Normal => Trivial
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.???


Comment:

 It's really not that severe, is it?

 All that happens is that authorities will test and report their own
 reachability:

 {{{
 [notice] Now checking whether ORPort (address redacted) and DirPort
 (address redacted) are reachable... (this may take up to 20 minutes --
 look for log messages indicating success)
 [info] consider_testing_reachability(): Testing reachability of my ORPort:
 (address redacted).
 }}}

 This might even be considered a feature - authorities on the public tor
 network should always have their reachability tests succeed, and chutney
 authorities set AssumeReachable, so they'll never see these messages.

 We should eventually fix up the log messages that are triggered when
 reachability testing fails:

 {{{
 [info] circuit_testing_failed(): Our testing circuit (to see if your
 ORPort is reachable) has failed. I'll try again later.
 [warn] Your server (address redacted) has not managed to confirm that its
 ORPort is reachable. Relays do not publish descriptors until their ORPort
 and DirPort are reachable. Please check your firewalls, ports, address,
 /etc/hosts file, etc.
 [warn] Your server (address redacted) has not managed to confirm that its
 DirPort is reachable. Relays do not publish descriptors until their ORPort
 and DirPort are reachable. Please check your firewalls, ports, address,
 /etc/hosts file, etc.
 }}}

 Really, all we need to do is choose between this message for relays:
 {{{
 Relays do not publish descriptors until their ORPort and DirPort are
 reachable. Please check your firewalls, ports, address, /etc/hosts file,
 etc.
 }}}
 and this message for authorities (auth_dir_any_non_hidserv()):
 {{{
 Authorities always publish directory documents, regardless of whether
 their ORPort and DirPort are reachable.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19013#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online