[tor-bugs] #19134 [Core Tor/Tor]: Shared Random: INT_8 means 8 bytes, not 8 bits

[Tor Bug Tracker & Wiki]

#19134: Shared Random: INT_8 means 8 bytes, not 8 bits
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs
Actual Points:                |  Parent ID:  #16943
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 generate_srv should take 8 bytes of reveal_num and version, not 8 bits.

 This is going to require a synchronous upgrade of our test network, isn't
 it?

 It will also require a htonll() that works on all platforms, which we
 don't currently have. We should move the htonll() code from test_util.c to
 util.c.

 (And arma shouldn't deploy shared random until this is done, right?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19134>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online