[tor-bugs] #16943 [Core Tor/Tor]: Implement prop250 (Random Number Generation During Tor Voting)

[Tor Bug Tracker & Wiki]

#16943: Implement prop250 (Random Number Generation During Tor Voting)
---------------------------------------+-----------------------------------
 Reporter:  asn                        |          Owner:  dgoulet
     Type:  enhancement                |         Status:  needs_revision
 Priority:  High                       |      Milestone:  Tor:
Component:  Core Tor/Tor               |  0.2.9.x-final
 Severity:  Normal                     |        Version:
 Keywords:  tor-hs, TorCoreTeam201605  |     Resolution:
Parent ID:  #8244                      |  Actual Points:
 Reviewer:  nickm                      |         Points:  6
                                       |        Sponsor:  SponsorR-must
---------------------------------------+-----------------------------------

Comment (by teor):

 I've split off everything that hasn't been included in
 dgoulet/ticket16943_029_02 into child tickets.

 Here's what has happened to T1-T9 and my branch sr-commit-fixes:

 37655c1 Improve log messages for SR commit lines (T5)
 has been fixup'd into another commit in dgoulet/ticket16943_029_02

 520e14f Fix a bug in shared random version parsing on 32-bit platforms
 (T6)
 has been fixup'd into another commit in dgoulet/ticket16943_029_02

 2fd8a21 Consistently use uint32_t for integers in shared random structs
 (T7)
 Split off into #19126, rebased on the latest dgoulet/ticket16943_029_02

 d6487a3 Silence a clang warning about shared random buffer sizes (T1)
 issue was fixed by b9b9022 prop250: Pass the dst length to sr_srv_encode()

 bc7160c Make a shared random log message easier to understand (T3)
 has been fixup'd into another commit in dgoulet/ticket16943_029_02

 add23bd Move the SR flag to the same place as the other SR ns string
 constants
 has been fixup'd into another commit in dgoulet/ticket16943_029_02

 3731984 Don't crash authorities when they have 254 or more shared random
 reveals
 Split off into #19126

 8a84070 Sort commits in lexicographical order in votes (T4)
 cherry-picked as 4d956a6 prop250: Sort commits in lexicographical order in
 votes

 The unit test fixes in ticket16943_029_02 have a bug on platforms where
 time_t is 32 bit (T9)
 Split off into #19125

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16943#comment:69>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online