[tor-bugs] #19074 [Core Tor/Tor]: Mark fallback directories down when their key is wrong

[Tor Bug Tracker & Wiki]

#19074: Mark fallback directories down when their key is wrong
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
Component:  Core Tor/Tor                         |  0.2.8.x-final
 Severity:  Normal                               |        Version:
 Keywords:  must-fix-before-0283, must-fix-      |     Resolution:
  before-028-rc                                  |  Actual Points:
Parent ID:  #18809                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 You see in {{{circuit_build_failed()}}} where we call
 {{{
       entry_guard_register_connect_status(n_chan_id, 0, 1, time(NULL));
       /* if there are any one-hop streams waiting on this circuit, fail
        * them now so they can retry elsewhere. */
       connection_ap_fail_onehop(n_chan_id, circ->build_state);
 }}}
 ?

 But you see the places in connection_or.c where we call
 {{{entry_guard_register_connect_status(failed)}}} without also calling
 {{{connection_ap_fail_onehop()}}}?

 I think we want a separate function to do all the smart things we should
 do when we we just decided that a pending OR connection attempt isn't
 going to work, and then call that new function consistently.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19074#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online