[tor-bugs] #18616 [Core Tor/Tor]: Make begindir advertise checks consistent with DirPort checks

[Tor Bug Tracker & Wiki]

#18616: Make begindir advertise checks consistent with DirPort checks
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  teor
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:  Tor:
Component:  Core Tor/Tor                         |  0.2.8.x-final
 Severity:  Normal                               |        Version:  Tor:
 Keywords:  regression, must-fix-before-028-rc,  |  0.2.8.1-alpha
  TorCoreTeam201605, TorCoreTeam-                |     Resolution:  fixed
  postponed-201604, review-group-1               |  Actual Points:  25
Parent ID:                                       |  hours
 Reviewer:  arma,teor                            |         Points:  3
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Replying to [comment:33 teor]:
 > Yes, if a relay operator sets DisableNetwork while the user updates the
 config, we shouldn't be testing ORPort reachability. I think it was still
 possible to do that.

 For posterity, I found another edge case like this one while working on
 this patch, and filed it under #19069.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online