[tor-bugs] #18616 [Core Tor/Tor]: Make begindir advertise checks consistent with DirPort checks

[Tor Bug Tracker & Wiki]

#18616: Make begindir advertise checks consistent with DirPort checks
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  regression, must-fix-before-028-rc,  |        Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-                |  0.2.8.1-alpha
  postponed-201604, review-group-1               |     Resolution:
Parent ID:                                       |  Actual Points:  25
 Reviewer:  arma                                 |  hours
                                                 |         Points:  medium
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => merge_ready
 * actualpoints:  20 hours => 25 hours


Comment:

 Replying to [comment:38 arma]:
 > My {{{bug18616-v4}}} branch has some fixes on the changes file, as well
 as some comment fixes, as well as a bit of refactoring to pass
 {{{options}}} around a bit more.
 >
 > If you like these changes, I think we're all set here.

 Looks good, let's get arma's `bug18616-v4` merged to 0.2.8 to fix #12538,
 which is already in 0.2.8.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18616#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online