[tor-bugs] #14013 [Core Tor/Tor]: base16_decode() API is inconsistent and error-prone

[Tor Bug Tracker & Wiki]

#14013: base16_decode() API is inconsistent and error-prone
-----------------------------------+------------------------------------
 Reporter:  nickm                  |          Owner:  nikkolasg
     Type:  defect                 |         Status:  needs_revision
 Priority:  High                   |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor           |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  lorax, review-group-1  |  Actual Points:
Parent ID:                         |         Points:  small
 Reviewer:  dgoulet                |        Sponsor:  SponsorS-can
-----------------------------------+------------------------------------

Comment (by nikkolasg):

 I get it, no worry, I'm just not used yet to your formatting :)
 I'll fix those and submit a new patch, maybe not *quickly* because I've
 just found some unchanged calls to base16_decode that I need to fix also
 (still some `base16_decode(..) == 0`).
 Thanks for the review anyway. I'll get back to you soon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14013#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online