[tor-bugs] #18886 [Applications/Tor Browser]: consider removing Pocket

[Tor Bug Tracker & Wiki]

#18886: consider removing Pocket
---------------------------------------------+-----------------------------
 Reporter:  mcs                              |          Owner:
     Type:  defect                           |  arthuredelstein
 Priority:  Medium                           |         Status:
Component:  Applications/Tor Browser         |  needs_review
 Severity:  Normal                           |      Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605R  |        Version:
Parent ID:                                   |     Resolution:
 Reviewer:                                   |  Actual Points:
                                             |         Points:
                                             |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by arthuredelstein):

 * status:  reopened => needs_review


Comment:

 I understand the behavior better now. After studying the pocket code
 carefully I came up with the following patch to tor-browser.git. Please
 note that the "browser.pocket.enabled" patch only takes effect after
 restart. That's consistent with the behavior of Pocket itself, which is
 not enabled or disabled until after restart.

 https://github.com/arthuredelstein/tor-browser/commit/18886+3
 Hash 6844e1209e7c509c8dc67570567e61c38061f72d

 This supersedes the torbutton patch in comment:10, which should not be
 used.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18886#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online