[tor-bugs] #18958 [Applications/Tor Browser]: screen.orientation should lie

[Tor Bug Tracker & Wiki]

#18958: screen.orientation should lie
---------------------------------------------+-----------------------------
 Reporter:  mcs                              |          Owner:
     Type:  defect                           |  arthuredelstein
 Priority:  Medium                           |         Status:
Component:  Applications/Tor Browser         |  needs_review
 Severity:  Normal                           |      Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201605R  |        Version:
Parent ID:                                   |     Resolution:
 Reviewer:                                   |  Actual Points:
                                             |         Points:
                                             |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by mcs):

 Replying to [comment:6 arthuredelstein]:
 > Thanks for the review. Here's a new version that blocks
 "orientationchange" and "mozorientationchange" events from being
 dispatched. I also blocked the use of 'screen.mozLockOrientation' and
 'screen.mozUnlockOrientation' for a similar reason.
 >
 > ​https://github.com/arthuredelstein/tor-browser/commits/18958+2
 > Hash 4f86b15a2a7d3ea4e370cf48fa247386cfb0157a

 r=brade, r=mcs
 This looks good to us.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18958#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online