[tor-bugs] #14013 [Core Tor/Tor]: base16_decode() API is inconsistent and error-prone

[Tor Bug Tracker & Wiki]

#14013: base16_decode() API is inconsistent and error-prone
-----------------------------------+------------------------------------
 Reporter:  nickm                  |          Owner:  nikkolasg
     Type:  defect                 |         Status:  needs_revision
 Priority:  High                   |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor           |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  lorax, review-group-1  |  Actual Points:
Parent ID:                         |         Points:  small
 Reviewer:                         |        Sponsor:  SponsorS-can
-----------------------------------+------------------------------------

Comment (by nikkolasg):

 Oups, I thought I could remove the first patch but no..
 Adapted the code for your first two points.
 About the third:
  - Value 17B1C409A7B0E9A9E307D38A18AF7E5F8C15C803
  - Size of output 20 (vs 32)
  - Failing tests:
     - dir/clip_unmeasured_bw_kb
     - dir/clip_unmeasured_bw_kb_alt
     - dir/v3_networkstatus

 If you'd like I can try to debug it further but to be honest, I think a
 more experienced Tor developer will be far most efficient (=fast) than me
 as I have to understand the whole codebase evolving around this line. That
 said, I'm willing to try ;)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14013#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online