[tor-bugs] #17406 [Applications/Tor Browser]: Include SelfRando patches into our hardened builds

[Tor Bug Tracker & Wiki]

#17406: Include SelfRando patches into our hardened builds
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_review
Component:  Applications/Tor Browser             |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-security, GeorgKoppen201605,     |     Resolution:
  tbb-hardened, TorBrowserTeam201605R            |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:9 boklm]:
 > I didn't try to build it yet (I started one but it's not finished yet),
 but it looks good.
 >
 > One small thing, in `RelativeLink/start-tor-browser`, with this line:
 > {{{
 > LD_LIBRARY_PATH="${HOME}/TorBrowser/Tor/:${LD_LIBRARY_PATH}"
 > }}}
 >
 > I think that when `$LD_LIBRARY_PATH` is undefined, it is similar to
 adding `.` to the library path, which might cause some problems.

 Yes, and I think we want to make sure that Tor Browser is only starting
 with the `LD_LIBRARY_PATH` we intended. Thus, I removed
 `:${LD_LIBRARY_PATH}`. bug_17406_v3 (https://gitweb.torproject.org/user/gk
 /tor-browser-bundle.git/commit/?h=bug_17406_v3) contains this and a small
 comment fixup.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17406#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online