[tor-bugs] #18363 [Core Tor/Tor]: Tor could use a publish/subscribe abstraction

Tue May 10 20:38:41 UTC 2016

#18363: Tor could use a publish/subscribe abstraction
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
 Priority:  High                                 |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  modularity, tor-modularity,          |        Version:
  TorCoreTeam201605, TorCoreTeam-                |     Resolution:
  postponed-201604                               |  Actual Points:
Parent ID:                                       |         Points:  medium
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 > Why gratuitously polluting the namespace of every consumer of
 "pubsub.h"?

 The implementation macros use these functions.  The alternative would be
 to rename them and stick them in the macros.  That didn't seem to have
 much point IMO.

 > Yeah, no.

 Please spell it out for me.

 >  s/DEFINE/DECLARE/g.

 Ah, that one.  Sounds reasonable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18363#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online