[tor-bugs] #18915 [Applications/Tor Browser]: Omnibox in a non-english Tor Browser has no Disconnect.me as search engine in 6.0a5

[Tor Bug Tracker & Wiki]

#18915: Omnibox in a non-english Tor Browser has no Disconnect.me as search engine
in 6.0a5
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  defect                               |         Status:
 Priority:  Very High                            |  needs_review
Component:  Applications/Tor Browser             |      Milestone:
 Severity:  Critical                             |        Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R,     |     Resolution:
  GeorgKoppen201605                              |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:8 anonym]:
 > Replying to [comment:7 gk]:
 > > Adding anonym, as I don't know how Tails is doing the localization and
 whether they are using the lang packs we ship or not.
 >
 > Thanks for thinking about us! :)
 >
 > In Tails we do localization essentially like this:
 >
 > * We install all your langpacks in the extensions directory, then Tor
 Browser picks the right one according to the `LANG` env var. Furthermore,
 it will pick localized search plugins from
 `distribution/searchplugins/locale/$LANGCODE/` (used below).

 Okay, you should be fine then I think.

 > * We dynamically generate localized search plugins for Disconnect,
 Startpage and Wikipedia, replacing your variants of these. Since we
 provide the English Wikipedia plugin for all locales, we generate
 localized icons (using imagemagick) for Wikipedia, by putting the lang
 code in the bottom-right corner.
 >
 > * We also install all search plugins from Debian's `ìceweasel-l10n-*`
 for which we have langpacks. (Personally I'd happily drop these since they
 mainly seem to add commercial crap.)
 >
 > So, we are not affected by this bug since we generate our own thing.
 However, I worked on integrating 6.0a5 into Tails yesterday and noticed a
 related issue (for us), namely that you now put your search engine plugins
 inside `distribution/omni.ja`, which makes it harder for us to *replace*
 them. I guess the best, touch, would be if we settled on the same search
 plugins, and we did nothing regarding this on Tails' side. I also realize
 that this is not the right ticket for this -- if you think there's an
 interest in harmonizing this I can open a new ticket.

 If that helps you then let's look at it. However, I am not sure I
 understand you. We actually did not change anything with our switch from
 ESR38 to ESR45 which is why we have this bug :). Specifically, we don't
 put our search engines into `distribution/omni.ja`. If I extract e.g. the
 Linux 32bit en-US bundle, the only omni.ja files I get are
 `Browser/omni.ja`, `Browser/browser/omni.ja` and
 `Browser/webapprt/omni.ja`. The search engines are still in the second
 one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18915#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online