[tor-bugs] #18907 [Core Tor/Tor]: tor_gettimeofday_cached_monotonic, as designed, could stall indefinitely

[Tor Bug Tracker & Wiki]

#18907: tor_gettimeofday_cached_monotonic, as designed, could stall indefinitely
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  small
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by mikeperry):

 As I said last week on IRC, I did question these. I'm not sure that this
 actually solves the problem of stalling. Based on running through this by
 hand on paper, it seems like we will just be maintaining the offset
 permanently as the delta of the backwards clock jump. This means that the
 function will continue to return times at least offset seconds in the
 future from the current clock. This means that when timeouts are scheduled
 by #18365, they will always be offset seconds late when they fire (since
 they are scheduled relative to this function and not the current time).

 Nick, last week, you agreed to test that. Did you? If not, I don't think
 this is in. And I still object as I did before until that point.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18907#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online