[tor-bugs] #18963 [Core Tor/Tor]: Download authority certificates even under blackholed authorities or fallbacks

[Tor Bug Tracker & Wiki]

#18963: Download authority certificates even under blackholed authorities or
fallbacks
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,              |        Version:  Tor:
  029-proposed                                   |  0.2.8.1-alpha
Parent ID:  #18816                               |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:  small
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Shadowing bug:
 {{{
 +  /* Look up the routerstatus for the dir_hint  */
 +  const routerstatus_t *rs = NULL;
 +
 +  if (dir_hint) {
 +    /* First try the consensus routerstatus, then the fallback
 +     * routerstatus */
 +    const routerstatus_t *rs =
 router_get_consensus_status_by_id(dir_hint);
 }}}

 That inner declaration of rs shouldn't be a declaration.

 Other than that, looks good.  One thing I would like to make sure I
 understand, though: what is it that makes us -not- retry the same
 directory server forever here?  Is it the fact that if that server at some
 point refuses to give us a certificate we asked for, we will then try to
 download it with dir_hint set to NULL?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18963#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online