[tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a DirPort
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,              |        Version:
  TorCoreTeam201605                              |     Resolution:
Parent ID:  #18809                               |  Actual Points:  2 hours
 Reviewer:  nickm                                |         Points:  small
                                                 |        Sponsor:  None
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:13 nickm]:
 > NOTE to '''nickm''': I'll have to rebase this one last time since I went
 and squashed and merged #18921.  That's on me, though.

 I did the rebase into my branch feature18483-028-v2 because of changes in
 #18929:

 Old commit / New commit / Name
 0de9faa a5b5447 Make clients always use begindir for directory requests
 15fe5e8 950eae4 Make clients only select directories with reachable
 ORPorts
 aec84c5 8febffe Only choose directory DirPorts on relays

 The following commits were deleted because this no longer depends on
 #18929:
 8adbfab Merge branch 'bug18921' into feature18483-028
 1100a70 Revert "Remove must_have_or from
 router_has_non_preferred_address_rs"
 5c8fde2 Only fall back to nodes with valid ORPorts when using begindir

 > 0de9faa402bebc98a58c9f65149e72e598926184:
 >   * begindir_reason will never be set!  You need to declare the `reason`
 argument in `directory_command_should_use_begindir` as "const char * *",
 not `const char *`.

 Oops! Pointer handling error.
 Calling this NM1.
 9f01dc4 fixup! Make clients always use begindir for directory requests

 > Otherwise, this looks good.

 Let's get it merged, I am much happier with it now it's disentangled and
 #18929 has shrunk.
 (And it merges fine on top of both maint-0.2.8 and the new #18929.)

 See #18962 for a rebased feature18483-cleanup-v2, which can go in 0.2.9.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18483#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online