[tor-bugs] #18483 [Core Tor/Tor]: Clients should always tunnel connections, and never fall back to a DirPort

[Tor Bug Tracker & Wiki]

#18483: Clients should always tunnel connections, and never fall back to a DirPort
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,              |        Version:
  TorCoreTeam201605                              |     Resolution:
Parent ID:  #18809                               |  Actual Points:  2 hours
 Reviewer:                                       |         Points:  small
                                                 |        Sponsor:  None
-------------------------------------------------+-------------------------

Comment (by nickm):

 NOTE to '''nickm''': I'll have to rebase this one last time since I went
 and squashed and merged #18921.  That's on me, though.

 0de9faa402bebc98a58c9f65149e72e598926184:
   * begindir_reason will never be set!  You need to declare the `reason`
 argument in `directory_command_should_use_begindir` as "const char * *",
 not `const char *`.

 Otherwise, this looks good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18483#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online