[tor-bugs] #18921 [Core Tor/Tor]: Fix IPv6 bridge client directory address selection

[Tor Bug Tracker & Wiki]

#18921: Fix IPv6 bridge client directory address selection
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc,              |        Version:  Tor:
  TorCoreTeam201605, TorCoreTeam-                |  0.2.8.1-alpha
  postponed-201604                               |     Resolution:
Parent ID:  #18483                               |  Actual Points:  1 hour
 Reviewer:  isis                                 |         Points:  small
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:9 nickm]:
 > This is kinda big for an rc/stable patch.  It looks okay and I think we
 need it and I'm okay with taking it anyway, but I'm also nominating it for
 my "I-told-you-so" award in case there is a bug here that none of us
 successfully found.

 You can blame me for a point release.
 I also split it into 3 branches so it's easier to review.

 > Initial Questions:
 >   * e726459eaf57ffe98c36730af58287229c9531d6: Are we really really sure
 that every possible case of the big complicated function
 directory_fetches_from_authorities() should be replaced with
 !directory_must_use_begindir() ?

 See my comment in #18483.

 >   * e155948d0ac54b3102d6efa3d4a689d8a177f0f4: This really really needs
 comments in the new code here.

 e155948d0ac54b3102d6efa3d4a689d8a177f0f4 is Choose the correct address for
 one-hop connections.
 This is now 4e0019e1409dffa20ddd6813b873565c0217a877 in my branch
 bug18921.

 I am happy to add comments, but I can't see where they are needed.
 Perhaps you meant another commit?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18921#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online