[tor-bugs] #18943 [Core Tor/Tor]: sha3 testsuite fails on big endian hosts

[Tor Bug Tracker & Wiki]

#18943: sha3 testsuite fails on big endian hosts
-------------------------------------------------+-------------------------
 Reporter:  weasel                               |          Owner:  yawning
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Major                                |  0.2.8.x-final
 Keywords:  tor-core, crypto, TorCoreTeam201605  |        Version:  Tor:
Parent ID:                                       |  0.2.8.2-alpha
 Reviewer:                                       |     Resolution:
                                                 |  Actual Points:
                                                 |         Points:  small-
                                                 |  remaining
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Replying to [comment:10 yawning]:
 > ​https://git.schwanenlied.me/yawning/tor/src/bug18943_squashed
 >
 > Passes the sha3 tests on debian stable running in a ppc qemu VM, and
 even fixes cpunk's nitpicks which will probably be replaced with other
 nitpicks.
 Thanks for fixing the nitpicks and for making IMO a beautiful patch.

 You're right, there is one more nitpick (sorry). The `i` variable
 declarations in the endianness conversion helpers can be placed inside the
 for loops (like is done in the `xorin8` and `setout8` functions). This
 will make the helpers even more compact and make the for loops consistent
 with the rest of the changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18943#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online