[tor-bugs] #18951 [Applications/Tor Browser]: Mac OS: HTTPS-E missing after update

[Tor Bug Tracker & Wiki]

#18951: Mac OS: HTTPS-E missing after update
--------------------------------------+--------------------------
 Reporter:  mcs                       |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Very High                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------
Changes (by mcs):

 * priority:  Medium => Very High


Comment:

 I noticed this problem while I was trying to reproduce #18947.  This one
 is caused by some code within the make_add_instruction function in tools
 /update-packaging/common.sh. It has some special handling for unpacked
 extensions that are located under distribution\/extensions. I do not know
 why, but instead of placing simple "add" instructions in the MAR file
 manifest it generates "add-if" instructions, e.g.,

 {{{
 add-if "Contents/Resources/distribution/extensions/https-everywhere-
 eff at eff.org" "Contents/Resources/distribution/extensions/https-everywhere-
 eff at eff.org/install.rdf"
 }}}

 Since Contents/Resources/distribution/extensions/https-everywhere-
 eff at eff.org does not exist in 6.0a4 or older releases, none of the files
 under https-everywhere-eff at eff.org/ are added during the update.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18951#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online