[tor-bugs] #18943 [Core Tor/Tor]: sha3 testsuite fails on big endian hosts
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon May 2 12:15:29 UTC 2016
#18943: sha3 testsuite fails on big endian hosts
------------------------------+------------------------------------
Reporter: weasel | Owner: yawning
Type: defect | Status: needs_revision
Priority: High | Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor | Version: Tor: 0.2.8.2-alpha
Severity: Major | Resolution:
Keywords: tor-core, crypto | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
------------------------------+------------------------------------
Changes (by yawning):
* status: needs_review => needs_revision
Comment:
Replying to [comment:3 cypherpunks]:
> According to [http://en.cppreference.com/w/c/language/identifier C11]
identifiers that begin with an underscore are reserved.
Don't care, it's macros swiped from `src/ext/csiphash.c`. Abstracting it
out into a common header file would be a good idea in the future, but is
beyond the scope of this ticket.
> Also i would move line 242 to line 246 so the change becomes similar to
that of `foldP` and `setout` and the comment wouldn't need to be
duplicated.
Meh.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18943#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list