[tor-bugs] #18943 [Core Tor/Tor]: sha3 testsuite fails on big endian hosts

[Tor Bug Tracker & Wiki]

#18943: sha3 testsuite fails on big endian hosts
------------------------------+------------------------------------
 Reporter:  weasel            |          Owner:  yawning
     Type:  defect            |         Status:  needs_review
 Priority:  High              |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor      |        Version:  Tor: 0.2.8.2-alpha
 Severity:  Major             |     Resolution:
 Keywords:  tor-core, crypto  |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------------

Comment (by weasel):

 on 0c95e52c17da1e11f131d00ea9f52e60a70a41c4:

 {{{
 gcc -DHAVE_CONFIG_H -I. -I..  -I../src/ext -Isrc/ext -I../src/ext/trunnel
 -I../src/trunnel -I../src/common -Isrc/common -I../src/ext/trunnel
 -I../src/trunnel -I../src/or -Isrc/or
 -DSHARE_DATADIR="\"/usr/local/share\""
 -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\""
 -I../src/common     -g -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all
 -Wstack-protector -fwrapv --param ssp-buffer-size=1 -fPIE -fasynchronous-
 unwind-tables -Wall -fno-strict-aliasing -W -Wfloat-equal -Wundef
 -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings
 -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2 -Wwrite-strings
 -Wmissing-declarations -Wredundant-decls -Wnested-externs -Wbad-function-
 cast -Wswitch-enum -Werror -Winit-self -Wmissing-field-initializers -Wold-
 style-definition -Waddress -Wmissing-noreturn -Wstrict-overflow=1
 -Wnormalized=id -Woverride-init -Wextra -Warray-bounds -Wlogical-op -MT
 src/ext/keccak-tiny/src_ext_keccak_tiny_libkeccak_tiny_a-keccak-tiny-
 unrolled.o -MD -MP -MF src/ext/keccak-tiny/.deps
 /src_ext_keccak_tiny_libkeccak_tiny_a-keccak-tiny-unrolled.Tpo -c -o
 src/ext/keccak-tiny/src_ext_keccak_tiny_libkeccak_tiny_a-keccak-tiny-
 unrolled.o `test -f 'src/ext/keccak-tiny/keccak-tiny-unrolled.c' || echo
 '../'`src/ext/keccak-tiny/keccak-tiny-unrolled.c
 ../src/ext/keccak-tiny/keccak-tiny-unrolled.c: In function 'hash':
 ../src/ext/keccak-tiny/keccak-tiny-unrolled.c:361:8: error: 's.delim' may
 be used uninitialized in this function [-Werror=maybe-uninitialized]
    if (s->delim != KECCAK_DELIM_XOF)
         ^
 ../src/ext/keccak-tiny/keccak-tiny-unrolled.c:402:16: note: 's' was
 declared here
    keccak_state s;
                 ^
 cc1: all warnings being treated as errors
 Makefile:4433: recipe for target 'src/ext/keccak-tiny
 /src_ext_keccak_tiny_libkeccak_tiny_a-keccak-tiny-unrolled.o' failed
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18943#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online